Skip to content

Avoid clang 21/22 C++26-mode frontend crash in StringLiteral's variadic constructor #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aruisdante wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

Avoid clang 21/22 C++26-mode frontend crash in StringLiteral's variadic constructor #688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions include/rfl/internal/StringLiteral.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

#include <algorithm>
#include <array>
#include <concepts>
#include <string>
#include <string_view>

Expand All @@ -14,9 +15,11 @@ namespace internal {
/// for the parameters names in the NamedTuples.
template <size_t N>
struct StringLiteral {
constexpr StringLiteral(const auto... _chars)
requires (std::is_same_v<decltype(_chars), const char> && ...)
: arr_{_chars..., '\0'} {}
/// Constrained via template type parameters rather than a requires-fold
/// over decltype of the function parameter pack: the latter crashes
/// clang 21/22 in C++26 mode (llvm/llvm-project#198052, #205000).
template <std::same_as<char>... Chars>
constexpr StringLiteral(const Chars... _chars) : arr_{_chars..., '\0'} {}

constexpr StringLiteral(const std::array<char, N> _arr) : arr_(_arr) {}

Expand Down
Loading