-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Support Node v26 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ jobs: | |
| uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 | ||
| with: | ||
| node-version-file: "package.json" | ||
| - name: Install Yarn (if not yet installed) | ||
| run: yarn --version || npm install -g [email protected] | ||
| - name: Install dependencies | ||
| run: yarn install --ignore-engines --ignore-scripts --frozen-lockfile | ||
| - name: Lint | ||
|
|
@@ -54,6 +56,10 @@ jobs: | |
| container: ghcr.io/getsentry/sentry-test-ubuntu-20.04-amd64:0dd255f3d41d013c1db4c4e08ffd22ee7959c3cc | ||
| node: 24 | ||
| binary: linux-x64-glibc-137 | ||
| - os: ubuntu-22.04 | ||
| container: ghcr.io/getsentry/sentry-test-ubuntu-20.04-amd64:0dd255f3d41d013c1db4c4e08ffd22ee7959c3cc | ||
| node: 26 | ||
| binary: linux-x64-glibc-147 | ||
|
|
||
| # x64 musl | ||
| - os: ubuntu-22.04 | ||
|
|
@@ -72,6 +78,10 @@ jobs: | |
| container: node:24-alpine3.20 | ||
| node: 24 | ||
| binary: linux-x64-musl-137 | ||
| - os: ubuntu-22.04 | ||
| container: node:26-alpine3.22 | ||
| node: 26 | ||
| binary: linux-x64-musl-147 | ||
|
|
||
| # arm64 glibc | ||
| - os: ubuntu-22.04 | ||
|
|
@@ -90,6 +100,10 @@ jobs: | |
| arch: arm64 | ||
| node: 24 | ||
| binary: linux-arm64-glibc-137 | ||
| - os: ubuntu-22.04 | ||
| arch: arm64 | ||
| node: 26 | ||
| binary: linux-arm64-glibc-147 | ||
|
|
||
| # arm64 musl | ||
| - os: ubuntu-22.04 | ||
|
|
@@ -112,6 +126,11 @@ jobs: | |
| container: node:24-alpine3.20 | ||
| node: 24 | ||
| binary: linux-arm64-musl-137 | ||
| - os: ubuntu-22.04 | ||
| arch: arm64 | ||
| container: node:26-alpine3.22 | ||
| node: 26 | ||
| binary: linux-arm64-musl-147 | ||
|
|
||
| # macos x64 | ||
| - os: macos-15-intel | ||
|
|
@@ -130,6 +149,10 @@ jobs: | |
| node: 24 | ||
| arch: x64 | ||
| binary: darwin-x64-137 | ||
| - os: macos-15-intel | ||
| node: 26 | ||
| arch: x64 | ||
| binary: darwin-x64-147 | ||
|
|
||
| # macos arm64 | ||
| - os: macos-15 | ||
|
|
@@ -152,6 +175,11 @@ jobs: | |
| node: 24 | ||
| target_platform: darwin | ||
| binary: darwin-arm64-137 | ||
| - os: macos-15 | ||
| arch: arm64 | ||
| node: 26 | ||
| target_platform: darwin | ||
| binary: darwin-arm64-147 | ||
|
|
||
| # windows x64 | ||
| - os: windows-2022 | ||
|
|
@@ -170,6 +198,10 @@ jobs: | |
| node: 24 | ||
| arch: x64 | ||
| binary: win32-x64-137 | ||
| - os: windows-2022 | ||
| node: 26 | ||
| arch: x64 | ||
| binary: win32-x64-147 | ||
|
|
||
| steps: | ||
| - name: Setup (alpine) | ||
|
|
@@ -191,6 +223,9 @@ jobs: | |
| with: | ||
| node-version: ${{ matrix.node }} | ||
|
|
||
| - name: Install Yarn (if not yet installed) | ||
| run: yarn --version || npm install -g [email protected] | ||
|
|
||
| - name: Increase yarn network timeout on Windows | ||
| if: contains(matrix.os, 'windows') | ||
| run: yarn config set network-timeout 600000 -g | ||
|
|
@@ -209,6 +244,22 @@ jobs: | |
| with: | ||
| python-version: "3.9.13" | ||
|
|
||
| # Node 26 V8 headers include <source_location>, which requires a newer C++ toolchain. | ||
| # Our ubuntu-20.04 glibc container defaults to an older compiler, so upgrade only this target. | ||
| - name: Setup compiler (Node 26 glibc x64) | ||
| if: matrix.binary == 'linux-x64-glibc-147' | ||
| run: | | ||
| # The base container ships a stale Yarn apt source with an expired/missing key. | ||
| # Remove it so apt-get update can succeed for toolchain installation. | ||
| rm -f /etc/apt/sources.list.d/yarn.list | ||
| apt-get update | ||
| apt-get install -y software-properties-common | ||
| add-apt-repository -y ppa:ubuntu-toolchain-r/test | ||
| apt-get update | ||
| apt-get install -y gcc-12 g++-12 | ||
| echo "CC=gcc-12" >> "$GITHUB_ENV" | ||
| echo "CXX=g++-12" >> "$GITHUB_ENV" | ||
|
|
||
| - name: Setup (arm64| ${{ contains(matrix.container, 'alpine') && 'musl' || 'glibc' }}) | ||
| if: matrix.arch == 'arm64' && !contains(matrix.container, 'alpine') && matrix.target_platform != 'darwin' | ||
| run: | | ||
|
|
@@ -286,6 +337,9 @@ jobs: | |
| with: | ||
| node-version-file: "package.json" | ||
|
|
||
| - name: Install Yarn (if not yet installed) | ||
| run: yarn --version || npm install -g [email protected] | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --ignore-engines --ignore-scripts --frozen-lockfile | ||
|
|
||
|
|
@@ -324,7 +378,7 @@ jobs: | |
| macos-15-intel, # macOS x64 | ||
| windows-latest, | ||
| ] | ||
| node: [18, 20, 22, 24, 25] | ||
| node: [18, 20, 22, 24, 26] | ||
| steps: | ||
| - name: Check out current commit | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.