ref(transport): Remove redundant checks for dsn#6104
Open
psh9508 wants to merge 1 commit intogetsentry:masterfrom
Open
ref(transport): Remove redundant checks for dsn#6104psh9508 wants to merge 1 commit intogetsentry:masterfrom
psh9508 wants to merge 1 commit intogetsentry:masterfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
What changed
Removed the redundant
is not Nonecheck from the DSN conditional statement inTransport.init(transport.py).Code Comparison:
Why
In Python, the truthiness check (
options["dsn"]) inherently evaluatesNoneas falsy. Therefore, the explicitis not Noneguard is redundant. Removing it simplifies the logic while maintaining the same behavior.Notes
options.get('dsn')? While.get()is often used for safe dictionary access, a default value for"dsn"is already guaranteed in this context, so there is no risk of aKeyError.options["dsn"]) to remain consistent with the existing coding pattern used later in the same file (e.g., line 1165:if options["dsn"]:).