ref(hub): Remove boolean to track if we are using process hub#1125
Merged
szokeasaurusrex merged 1 commit intoMay 26, 2026
Conversation
szokeasaurusrex
commented
May 8, 2026
| { | ||
| THREAD_HUB.with(|(hub, is_process_hub)| { | ||
| if is_process_hub.get() { | ||
| f(&PROCESS_HUB.hub) |
Member
Author
There was a problem hiding this comment.
As I understand it, this was the sole purpose of is_process_hub: so that when we are on the thread that created the hub, the current hub is the PROCESS_HUB.
The changes here eliminate the need to track is_process_hub separately, since we just make the thread hub an arc-clone of the process hub on the thread that creates the process hub.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/process-hub-struct
branch
from
abb5eb3 to
a5add5a
Compare
Instead, it is simpler just to set the `THREAD_HUB` to the `PROCESS_HUB` (or, more specifically, an Arc-clone of it).
szokeasaurusrex
force-pushed
the
szokeasaurusrex/thread-hub-simplification
branch
2 times, most recently
from
752cbbc to
87d0c23
Compare
szokeasaurusrex
added a commit
that referenced
this pull request
May 26, 2026
Following the safety improvements in #1123, `Hub::with` no longer offers any performance benefit over using `Hub::current`. `Hub::current` provides a simpler API, and also returns an owned `Arc<Hub>` rather than providing access to a `&Arc<Hub>` via a callback (necessitating a second clone for anyone needing an owned `Arc<Hub>` in that callback). As `Hub::current` is the arguably better API, let's deprecate `Hub::with` and encourage folks to migrate. Stacked on #1125
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, it is simpler just to set the
THREAD_HUBto thePROCESS_HUB(or, more specifically, an Arc-clone of it).Stacked on #1124