Add write::CountingBuffer#930
Merged
Merged
Conversation
Move all position tracking from WritableBuffer into CountingBuffer. This allows WritableBuffer to be implemented for &mut [u8], which can then be used for elf::Encoder and macho::Encoder. This may also make it possible to support appending to a non-empty Vec, but I haven't allowed that yet. This removes WritableBuffer::len and WritableBuffer::resize. Also move WritableBuffer::write_pod and write_pod_slice to a new WritableBufferExt trait. This also replaces the write/write_slice methods that were implemented for dyn WritableBuffer, as well as some internal freestanding functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all position tracking from WritableBuffer into CountingBuffer.
This allows WritableBuffer to be implemented for &mut [u8], which can
then be used for elf::Encoder and macho::Encoder. This may also make it
possible to support appending to a non-empty Vec, but I haven't allowed
that yet.
This removes WritableBuffer::len and WritableBuffer::resize.
Also move WritableBuffer::write_pod and write_pod_slice to a new
WritableBufferExt trait. This also replaces the write/write_slice
methods that were implemented for dyn WritableBuffer, as well as
some internal freestanding functions.