Conversation
…finished Adds a test-rust target that runs cargo test in guards/github-guard/rust-guard/. The target degrades gracefully when cargo is not installed (same pattern as golangci-lint). Includes test-rust in agent-finished so agents making Rust changes automatically verify guard correctness before creating PRs. Also adds test-rust to the .PHONY list and help output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a make test-rust target to run Rust guard unit tests and wires Rust tests into the agent-finished workflow so Rust-related changes get exercised by default.
Changes:
- Introduces
test-rusttarget that runscargo testinguards/github-guard/rust-guard/, skipping with a warning ifcargois unavailable. - Extends
agent-finishedto run Rust unit tests after Go tests. - Updates
.PHONYandhelpoutput to include the new target.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds test-rust, documents it, and runs Rust tests as part of agent-finished. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
lpcox
deleted the
repo-assist/eng-rust-test-target-2026-04-18-7f8b4dfb8166a036
branch
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Adds a
test-rustMakefile target for running the Rust guard unit tests, and includes it inagent-finishedso agents making Rust changes automatically verify correctness before creating PRs.Changes
Makefile:test-rusttarget: runscargo testinguards/github-guard/rust-guard/. Degrades gracefully ifcargois not installed (prints a warning and skips, matching thegolangci-lintpattern).agent-finished: appends a Rust test step after the Go tests..PHONY: addstest-rust.help: documents the new target.Motivation
Agents editing Rust guard code (e.g.
lib.rs,tools.rs,labels/*.rs) had no automated way to verify the Rust tests viamake agent-finished. The 308 Rust unit tests were silently skipped. This caused a real gap: an agent could introduce a Rust regression and still see "✓ All agent-finished checks passed!". The new target closes that gap.Test Status
Go build/test blocked by pre-existing
proxy.golang.orgfirewall issue — unrelated to this change.Warning
The following domain was blocked by the firewall during workflow execution:
proxy.golang.orgTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.