Skip to content

Fix Skipf test format for Go vet - #160

Merged
gkampitakis merged 1 commit into
gkampitakis:mainfrom
HNO3Miracle:fix-skipf-test-format
Jun 22, 2026
Merged

Fix Skipf test format for Go vet#160
gkampitakis merged 1 commit into
gkampitakis:mainfrom
HNO3Miracle:fix-skipf-test-format

Conversation

@HNO3Miracle

Copy link
Copy Markdown
Contributor

Summary:

  • Keep the Skipf mock expectation as a format string plus arguments.
  • This avoids a non-constant format issue under current Go vet while preserving the test intent.

Testing:

  • go test ./snaps -run TestSkip

Note:

  • Full go test ./... is currently blocked in this local non-interactive environment by existing color snapshot expectations unrelated to this change.

Signed-off-by: HNO3Miracle <xiangao.or@isrc.iscas.ac.cn>
@gkampitakis

Copy link
Copy Markdown
Owner

Thank you for the pr

@gkampitakis
gkampitakis merged commit faff554 into gkampitakis:main Jun 22, 2026
4 checks passed
@HNO3Miracle
HNO3Miracle deleted the fix-skipf-test-format branch June 22, 2026 08:04
@HNO3Miracle

Copy link
Copy Markdown
Contributor Author

Amazing speed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants