Skip to content

bugfix: fix circular dep issues by creating separate enums - #8652

Closed
Yuri-510 wants to merge 1 commit into
mainfrom
yuri/app-routes-enum
Closed

bugfix: fix circular dep issues by creating separate enums#8652
Yuri-510 wants to merge 1 commit into
mainfrom
yuri/app-routes-enum

Conversation

@Yuri-510

@Yuri-510 Yuri-510 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

AB#XXXX

Describe your changes

fix circular dep issues by creating separate enums.

Checklist before requesting a code review

  • I have performed a self-review of my code
  • I have addressed all Copilot comments
  • I have asked the design team to review these changes, or: The changes do not touch the UI/UX
  • I have added tests for my changes, or: Adding tests is unnecessary/irrelevant
  • I have made sure that all automated checks pass before requesting a review
  • I have updated all documentation where necessary
  • I have checked the list of integrations with the 121 API for changed endpoints
  • I do not need any deviation from our PR guidelines

Portal preview-deployment

https://happy-rock-0411d2003-8652.westeurope.3.azurestaticapps.net

Copilot AI lite review requested due to automatic review settings August 11, 2026 07:27
@Yuri-510 Yuri-510 added the bugfix Something that affects our end users is fixed label Aug 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces circular-dependency risk in the Angular portal by extracting route-related enums out of app.routes.ts into dedicated enum files, and updating selected consumers to import those enums directly.

Changes:

  • Moved AppRoutes into interfaces/portal/src/app/enums/app-routes.enum.ts.
  • Moved ProgramMonitoringPaths into interfaces/portal/src/app/enums/program-monitoring-paths.enum.ts.
  • Updated auth/MSAL-related code to import AppRoutes from the new enum location (and re-exported enums from app.routes.ts for backwards compatibility).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
interfaces/portal/src/app/services/auth/strategies/msal-auth/msal-auth.strategy.ts Switches AppRoutes import to the extracted enum file.
interfaces/portal/src/app/services/auth/strategies/msal-auth/msal-auth.app-providers.ts Switches AppRoutes import to the extracted enum file.
interfaces/portal/src/app/services/auth.service.ts Switches AppRoutes import to the extracted enum file (helps break auth↔routes cycles).
interfaces/portal/src/app/enums/program-monitoring-paths.enum.ts New enum file for monitoring nested route segments.
interfaces/portal/src/app/enums/app-routes.enum.ts New enum file for top-level route segments.
interfaces/portal/src/app/app.routes.ts Removes inline enums, imports them from new files, and re-exports them for compatibility.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread interfaces/portal/src/app/enums/program-monitoring-paths.enum.ts
Comment on lines +15 to +16
export { AppRoutes } from '~/enums/app-routes.enum';
export { ProgramMonitoringPaths } from '~/enums/program-monitoring-paths.enum';
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something that affects our end users is fixed

Development

Successfully merging this pull request may close these issues.

2 participants