Refactor/setup dialog split - #749
Open
PartySensei wants to merge 5 commits into
Open
PartySensei wants to merge 5 commits into
PartySensei wants to merge 5 commits into
Conversation
- Wallet discovery and migration - Bitcoin Core directory and operation mode setup - Database configuration (local/remote) - Settings validation and persistence - WalletTypes enum refactoring (WLTTYPES -> WalletTypes) - Code quality improvements
PartySensei
force-pushed
the
refactor/setup-dialog-split
branch
from
January 9, 2026 11:38
072a49c to
4a99b7d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the
DlgSetupManager.pyinto a modularsetupmanagerpackage with separate files for each tab widget.Changes
New package:
qtdialogs/setupmanager/__init__.py- Package exportsDlgSetupManager.py- Main dialog shellWalletTab.py- Wallet settings tabCoreTab.py- Bitcoin Core settings tabDatabaseTab.py- Database settings tabModified files
ArmoryQt.py- Updated import pathqtdialogs/qtdefines.py- AddedcreateTabTitle()andcreateDirectoryInputLayout()helpersDeleted files
qtdialogs/DlgSetupManager.py- Replaced by packageNotes