Repository navigation
[bot] Merge master/588cad64 into rel/dev - #1875
Merged
Merged
Conversation
The Publisher content v2 model stores pages under `content`, optionally
grouped into sections, lays them out as typed widgets inside
`row`/`column` containers with `children`, references visualizations
as `{identifier, type}`, writes summaries as `takeaway` widgets and
states the period as a dashboard date filter. The document-skill
evaluator only understood the v1 shape, so a v2 draft failed every
structural check.
A document with top-level `version: "2"` is now read as v2: pages come
from `content`, falling back to the top level when `content` is
missing, sections are flattened in order (and win over `pages` if both
are present), visualization ids are read as a bare string or as
`{identifier}`, and title/heading widgets give the page heading. Only
`takeaway` widgets are summaries, and every one on a content page must
be written: the default page templates ship an empty `text` widget with
id `summary`, while the copilot writes its summaries into takeaways, so
that text widget is ignored. An absolute period is compared on
`from`/`to`; a relative one cannot match fixed dates and fails the
period check with the range it states.
Hidden pages (`visible: false`) are out of the viewer, exports and page
numbering, so they are left out of everything scored: the page count
the part and the tool report (which is what the user is told), the
cover/content rule, the chart and summary checks, and the page
numbering the judge reads.
v1 documents score exactly as before.
jira: LX-3336
risk: nonprod
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
feat(gooddata-eval): score v2 Publisher documents
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1875 +/- ##
===========================================
+ Coverage 84.65% 84.69% +0.03%
===========================================
Files 335 335
Lines 23696 23745 +49
===========================================
+ Hits 20061 20110 +49
Misses 3635 3635 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 588cad6 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/38425981363).