Mitigate pickle deserialization RCE risk in replay buffer checkpoints#237
Open
vijesh-cloud wants to merge 2 commits into
Open
Mitigate pickle deserialization RCE risk in replay buffer checkpoints#237vijesh-cloud wants to merge 2 commits into
vijesh-cloud wants to merge 2 commits into
Conversation
…dd remote path validation Replace pickle serialization with msgpack in replay buffers to eliminate pickle-based RCE vulnerabilities: - circular_replay_buffer.py: Added _pack/_unpack helpers, _validate_local_path guard, replaced pickle.dump/load - subsequence_replay_buffer.py: Same security fixes for labs-based buffer - Added type preservation for tuples, sets via __dopamine_type__ markers - Remote path validation rejects gs://, s3://, UNC, and other URI schemes - Tests: Added testLoadRejectsRemoteCheckpointPaths regression test - Also patched colab utils, pickle_collector, checkpointer, logger for consistency Validated: - All data types roundtrip correctly through msgpack serializer - Remote paths (gs://, s3://) are rejected before file I/O - Local filesystem paths continue to work normally - Existing checkpoint save/load tests pass
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR mitigates a potential remote code execution (RCE) risk arising from the use of Python's
picklemodule for replay buffer checkpoint serialization and deserialization.Changes
pickle-based checkpoint serialization/deserialization withmsgpackin replay buffer implementations.Files Updated
circular_replay_buffer.pysubsequence_replay_buffer.pypickle_collector.pycheckpointer.pylogger.pyValidation
gs://,s3://, UNC paths, and other URI-based locations are rejected before file I/O.Security Impact
Python's
pickledeserialization can execute arbitrary code when processing untrusted data. Replacing it with a safer serialization format and validating checkpoint paths reduces the risk of arbitrary code execution during checkpoint loading while preserving existing functionality for trusted local checkpoints.