fix(secops): validate alert_id and return structured dict for alert tools - #310
Open
dandye wants to merge 1 commit into
Open
fix(secops): validate alert_id and return structured dict for alert tools#310dandye wants to merge 1 commit into
dandye wants to merge 1 commit into
Conversation
…ools - Make alert_id a required parameter and validate against empty/None values - Return structured alert dictionary directly instead of raw json.dumps string - Update return type annotations and docstrings to Dict[str, Any] - Return structured error dictionary and log errors with exc_info - Fix copy-paste error in do_update_security_alert exception message - Add unit test coverage for validation, dict return shape, and error handling Fixes #265
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #265:
alert_id: stra required first parameter on bothget_security_alert_by_idanddo_update_security_alert, and added validation to prevent passingNoneor empty strings to the Chronicle SDK.json.dumps(...)) to structured dictionaries (Dict[str, Any]), matching the actual SDK output format and downstream client/test expectations.logger.error(..., exc_info=True)and return structured error dictionaries ({"error": ...}). Corrected copy-paste typo indo_update_security_alertexception message.Fixes #265
Verification
tests/test_security_alerts_unit.pytesting required parameter validation, structured dictionary return values, SDK call parameters, and error handling.