Conversation
180f460 to
917884e
Compare
917884e to
3201f87
Compare
3201f87 to
d8054ab
Compare
d8054ab to
c80085a
Compare
c80085a to
227476b
Compare
227476b to
4f9df7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds colocate mode to agentic cli. It does the following:
If offload is enabled and user specify rolllout_model_config.colocate_with="actor", the reference stage will block until the global batch barrier hits.
If offload is disabled and user specify rolllout_model_config.colocate_with="actor", that indicates there is enough HBM to host all the models, the pipeline will not block and fires asynchronously
If user doesn't specify rolllout_model_config.colocate_with and explicitly provide a rollout mesh, the pipeline runs in disagg mode.
Reference
Colab Notebook
Checklist