chore: remove name_pretty_override from librarian.yaml#16812
Open
jskeet wants to merge 9 commits intogoogleapis:mainfrom
Open
chore: remove name_pretty_override from librarian.yaml#16812jskeet wants to merge 9 commits intogoogleapis:mainfrom
jskeet wants to merge 9 commits intogoogleapis:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a large-scale update to product naming conventions across numerous client libraries, primarily by removing "Google" and "Google Cloud" prefixes from product names in metadata and documentation files. These changes are reflected in librarian configurations, repository metadata, and README files to ensure a more concise branding. I have no feedback to provide.
This isn't needed for handwritten libraries, and generated libraries should have values taken from sdk.yaml Towards googleapis/librarian#5463
jskeet
force-pushed
the
remove-name-pretty-override-2
branch
from
59fd8f8 to
59c3269
Compare
parthea
approved these changes
Apr 27, 2026
Contributor
|
@ohmayr Please could you check the reason that Do we need to add google-cloud-python/.github/workflows/bigtable-conformance.yaml Lines 19 to 28 in 84f15e3 |
parthea
added a commit
that referenced
this pull request
Apr 27, 2026
As of #16624, `django-google-spanner` presubmits are being triggered on every PR, regardless of whether `django-google-spanner` was changed. We should only trigger presubmit tests when there are changes to `django-google-spanner` or the action itself. See #16812 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't needed for handwritten libraries, and generated libraries should have values taken from sdk.yaml
Towards googleapis/librarian#5463