fix: support PyPI jupyter-kernel-client>=1.0 (JupyterKernelClient rename) - #125
theaathish wants to merge 2 commits into
Conversation
…ame) PyPI jupyter-kernel-client 1.x renamed KernelClient -> JupyterKernelClient. uv/pip installs of google-colab-cli resolve the unpinned dependency to 1.0.2, so colab exec fails with: AttributeError: module 'jupyter_kernel_client' has no attribute 'KernelClient' Resolve the client class as ColabKernelClient -> KernelClient -> JupyterKernelClient, keeping proxy_token vs token params correct.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Verified this patch independently. Took
Current main (465b941) fails on 1.0.1 and 1.0.2 only; the rest of that column is unchanged by this PR. Three notes for review: 1. Comparison with #99. That PR changes the same on 0.9.0 and on the googlecolab fork at the 2. This PR leaves the dependency unbounded.
3. |
Problem
Installing from PyPI (
uv tool install google-colab-cli/pip install google-colab-cli) resolves the unpinnedjupyter-kernel-clientdependency to 1.0.2, whereKernelClientwas renamed toJupyterKernelClient.colab execthen fails on any session (auth +colab status/colab lsstill work):Full traceback originates at
src/colab_cli/runtime.pyinColabRuntime.kernel_client(jupyter_kernel_client.KernelClient(...)).Repro (CLI 0.6.0 + PyPI jupyter-kernel-client 1.0.2):
Fix
Resolve the client class across all known variants in
ColabRuntime.kernel_client:ColabKernelClient(proxy_token=...)(git fork version)KernelClient(token=...)(PyPI <1.0)JupyterKernelClient(token=...)(PyPI >=1.0, fallback)The
JupyterKernelClientconstructor is compatible (passes through toKernelHttpManagervia**kwargs:server_url,token,kernel_id,client_kwargs,headers), verified live withcolab execafter patching.Tests
test_colab_runtime_kernel_clientto handle all three variants.test_colab_runtime_kernel_client_jupyterclient_fallbacksimulating PyPI>=1.0 (onlyJupyterKernelClientpresent).uv run pytest tests/test_runtime.py -v: 9 passed.uv run ruff check+ruff format --check: clean.echo "print('connection_test_ok')" | colab exec→connection_test_ok.