Update display size scale tests with video frame from video file#4614
Open
haoxli wants to merge 3 commits into
Open
Update display size scale tests with video frame from video file#4614haoxli wants to merge 3 commits into
haoxli wants to merge 3 commits into
Conversation
For display‑size scale tests, a VideoFrame created from a video file is the right source to validate importExternalTexture because it exercises the real decode, color conversion, and display‑size metadata path. A canvas ImageData frame bypasses the video decode path, so it’s removed. Added a focused video list to validate scaling across codec and color‑space variation, covering both codecs (VP9, H.264) and both color spaces (bt.601, bt.709). Issue: gpuweb#4605
shaoboyan091
self-requested a review
March 19, 2026 01:12
kainino0x
reviewed
Mar 19, 2026
Contributor
Author
I tested it pass on Intel GPU, but failed on NV GPU. It seems to be a tolerance issue or decoder differences on NVIDIA. I will check it again after we update the video file. |
haoxli
marked this pull request as draft
June 18, 2026 09:18
haoxli
marked this pull request as ready for review
July 16, 2026 05:58
kainino0x
reviewed
Jul 17, 2026
| topLeft: sample(displayWidth * 0.25, displayHeight * 0.25), | ||
| topRight: sample(displayWidth * 0.75, displayHeight * 0.25), | ||
| bottomLeft: sample(displayWidth * 0.25, displayHeight * 0.75), | ||
| bottomRight: sample(displayWidth * 0.75, displayHeight * 0.75), |
Collaborator
There was a problem hiding this comment.
Shouldn't these four sample points still correspond to the centers of the four solid colors? It's hard to understand what this sample logic is doing which makes it hard to verify the test is correct, compared with just expecting 4 different colors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For display‑size scale tests, a VideoFrame created from a video file is the right source to validate importExternalTexture because it exercises the real decode, color conversion, and display‑size metadata path. A canvas ImageData frame bypasses the video decode path, so it’s removed.
Added a focused video list to validate scaling across codec and color‑space variation, covering both codecs (VP9, H.264) and both color spaces (bt.601, bt.709).
Issue: #4605
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.