Texture compression unaligned#4676
Conversation
… texture-compression-unaligned, but succeeds otherwise.
…mpressed textures with unaligned sizes.
…igned dimensions.
|
Results for build job (at 359fd6c): -webgpu:api,operation,adapter,requestDevice:features,known:* - 24 cases, 24 subcases (~1/case)
+webgpu:api,operation,adapter,requestDevice:features,known:* - 25 cases, 25 subcases (~1/case)
+webgpu:api,operation,command_buffer,copyTextureToTexture:color_textures,compressed,unaligned,non_array:* - 94 cases, 1974 subcases (~21/case)
+webgpu:api,operation,command_buffer,image_copy:compressed_textures,unaligned_mip_level_0:* - 156 cases, 780 subcases (~5/case)
+webgpu:api,validation,capability_checks,features,texture_compression_unaligned:createTexture,unaligned_size:* - 416 cases, 416 subcases (~1/case)
-TOTAL: 283187 cases, 2326095 subcases
+TOTAL: 283854 cases, 2329266 subcases |
|
I added experimental support for the extension in Chromium that you can try with |
Thanks @Kangz! I tried with |
|
My bad, I thought the Chromium change trivial so I didn't check and I missed something. With that CL I can see the feature exposed locally (on mac M1) with |
|
And I can't land that last CL because the existing tests will enable |
|
Looking at the coverage, I think we should have at least one more test that samples a texture with unaligned mip level 0 and checks that the correct texel value is returned for the border (so the value in the middle of the block and not the border of the block itself). I'll land the Chromium CL and try to get agreement in the WebGPU WG to land the feature in the spec after testing is done. |
|
https://chromium-review.git.corp.google.com/c/chromium/src/+/8064574 landed in Chromium so it should soon be possible to test |
Issue: gpuweb/gpuweb#2006
Add tests to support the proposed 'texture-compression-unaligned' feature. gpuweb/gpuweb#6312
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.