Skip to content

fix: warn about ignored OTLP application name and labels - #348

Merged
korniltsev-grafanista merged 1 commit into
grafana:mainfrom
arnabnandy7:fix/otlp-label-warning
Aug 24, 2026
Merged

fix: warn about ignored OTLP application name and labels#348
korniltsev-grafanista merged 1 commit into
grafana:mainfrom
arnabnandy7:fix/otlp-label-warning

Conversation

@arnabnandy7

Copy link
Copy Markdown
Contributor

Documents the current OTLP export limitation and warns users that the configured application name and labels are not included in OTLP profiles. These profiles may therefore appear under service_name="unknown_service".

It also clarifies why LabelsWrapper.dump() is still called in OTLP mode: besides producing the labels snapshot, it removes closed scoped contexts and prevents them from accumulating.

Changes

  • Document the OTLP application name and label limitation in the README.
  • Log a warning at startup when OTLP export is enabled.
  • Add tests covering the warning.
  • Isolate PyroscopeAgentTest from native async-profiler initialization to make it portable across operating systems.
  • Explain why label state is drained even though OTLP export currently ignores the resulting snapshot.

Testing

./gradlew :agent:test --tests io.pyroscope.javaagent.PyroscopeAgentTest

3 tests completed, 0 failed
BUILD SUCCESSFUL

Closes #344.

@arnabnandy7
arnabnandy7 requested review from a team as code owners August 5, 2026 08:15
@arnabnandy7
arnabnandy7 force-pushed the fix/otlp-label-warning branch from 08e5495 to 3c340d7 Compare August 21, 2026 15:27

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3c340d7. Configure here.

Comment thread README.md Outdated
@arnabnandy7
arnabnandy7 force-pushed the fix/otlp-label-warning branch from 3c340d7 to c52f05a Compare August 21, 2026 15:33
@arnabnandy7

Copy link
Copy Markdown
Contributor Author

@korniltsev @korniltsev-grafanista please review this one as well, thanks.

Comment thread README.md Outdated
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
@korniltsev-grafanista
korniltsev-grafanista enabled auto-merge (squash) August 24, 2026 09:29
@korniltsev-grafanista
korniltsev-grafanista merged commit a1fe0a8 into grafana:main Aug 24, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OTLP export silently drops application name and labels

2 participants