fix: warn about ignored OTLP application name and labels - #348
Merged
korniltsev-grafanista merged 1 commit intoAug 24, 2026
Merged
Conversation
arnabnandy7
force-pushed
the
fix/otlp-label-warning
branch
from
August 21, 2026 15:27
08e5495 to
3c340d7
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3c340d7. Configure here.
arnabnandy7
force-pushed
the
fix/otlp-label-warning
branch
from
August 21, 2026 15:33
3c340d7 to
c52f05a
Compare
Contributor
Author
|
@korniltsev @korniltsev-grafanista please review this one as well, thanks. |
Signed-off-by: Arnab Nandy <arnab_nandy7@yahoo.com>
arnabnandy7
force-pushed
the
fix/otlp-label-warning
branch
from
August 22, 2026 10:21
c52f05a to
4866c0c
Compare
korniltsev-grafanista
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Documents the current OTLP export limitation and warns users that the configured application name and labels are not included in OTLP profiles. These profiles may therefore appear under
service_name="unknown_service".It also clarifies why
LabelsWrapper.dump()is still called in OTLP mode: besides producing the labels snapshot, it removes closed scoped contexts and prevents them from accumulating.Changes
PyroscopeAgentTestfrom native async-profiler initialization to make it portable across operating systems.Testing
Closes #344.