improve diff/code view experience in schema checks - #8396
Merged
Conversation
n1ru4l
changed the title
Collaborator
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-hive/gateway-plugin-console-sdk |
0.1.5-alpha-20260824092653-7b88ce1f17e5dfac39b06004e42249685a636671 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/yoga |
0.49.5-alpha-20260824092653-7b88ce1f17e5dfac39b06004e42249685a636671 |
npm ↗︎ unpkg ↗︎ |
hive |
11.12.1-alpha-20260824092653-7b88ce1f17e5dfac39b06004e42249685a636671 |
npm ↗︎ unpkg ↗︎ |
Contributor
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tags: |
n1ru4l
changed the title
n1ru4l
requested review from
dotansimha,
jdolle,
jonathanawesome and
kamilkisiela
August 24, 2026 09:33
n1ru4l
marked this pull request as ready for review
August 24, 2026 10:19
jdolle
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the monaco setup in schema checks with pierre/diffs, which we already use for schema versions (history).
Schema / Public SDL / Service Schema diff
Schema Policy
Note: The previous monaco thing was highlighting the inline code with an underline, but did not show the actual error message. Pierre/diffs does currently not support inline markers/gutters for view mode (see pierrecomputer/pierre#306).
I still thing the current UI is an improvement compared to before.