(wip) ref: action enum

[swissarmytowel]

Summary

Removes ActionType in favour of defining it in margin engines

Checklist

Ensure you completed all of the steps below before submitting your pull request:

• Add natspec for all functions / parameters
• Ran forge snapshot
• Ran forge fmt
• Ran forge test
• Triage Slither issues, and post uncertain ones in the PR

[github-actions]

Gas usage comparison:

Test Name	Gas Diff	Percentage Change
BaseEngineFlow:test()	⛽ +22	13.41%
BaseEngineFlow:testAddCollateralMoveBalance()	♻️ -234	-0.34%
BaseEngineFlow:testAddLongShouldMoveToken()	♻️ -440	-0.42%
BaseEngineFlow:testBurnActionShouldBurnOption()	♻️ -352	-0.60%
BaseEngineFlow:testCannotAddCollatFromOthers()	♻️ -239	-1.16%
BaseEngineFlow:testCannotAddLongFromOthers()	♻️ -227	-1.11%
BaseEngineFlow:testCannotBurnFromOthers()	♻️ -219	-0.99%
BaseEngineFlow:testCannotRemoveMoreThanEngineHas()	♻️ -477	-0.61%
BaseEngineFlow:testMintActionShouldMintOption()	♻️ -214	-0.35%
BaseEngineFlow:testRemoveCollateralMoveBalance()	♻️ -375	-0.57%
BaseEngineFlow:testRemoveLongShouldPullToken()	♻️ -446	-0.55%
BaseEngineFlow:testSettlementShouldEmitEvent()	♻️ -158	-0.59%
Deploy:testChill()	♻️ -22	-18.33%
PomaceAccessTest:test()	⛽ +22	13.41%
PomaceAccessTest:testAliceCanGrantAccess()	♻️ -100	-0.13%
PomaceAccessTest:testAliceCanGrantAccessToMaxSubAccount()	♻️ -78	-0.11%
PomaceAccessTest:testAliceCanRevokeAccess()	♻️ -245	-0.29%
PomaceAccessTest:testAliceCannotGrantAccessToMaxSubAccountPlusOne()	♻️ -100	-0.21%
PomaceAccessTest:testAllowanceDecrease()	♻️ -303	-0.31%
PomaceAccessTest:testCannotUpdateRandomAccount()	♻️ -145	-0.61%
PomaceAccessTest:testGranteeCanRevokeAccess()	♻️ -80	-0.22%

[codecov]

Codecov Report

Merging #18 (b27c034) into feature/burn-in-account (864fc3c) will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           feature/burn-in-account      #18   +/-   ##
========================================================
  Coverage                    65.10%   65.10%           
========================================================
  Files                           18       18           
  Lines                          364      364           
  Branches                        67       67           
========================================================
  Hits                           237      237           
  Misses                         111      111           
  Partials                        16       16           

Files	Coverage Δ
src/core/PhysicalOptionToken.sol	100.00% <ø> (ø)
src/core/engines/BaseEngine.sol	0.00% <ø> (ø)
src/core/engines/mixins/OptionTransferable.sol	0.00% <ø> (ø)
test/integration-tests/PomaceSettlement.t.sol	0.00% <ø> (ø)
test/libraries/TokenIdUtil.t.sol	100.00% <ø> (ø)
test/mocks/MockPhysicalEngine.sol	71.42% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more