feat(design): add configurable menu position and scrollable overflow#4541
Open
xelaint wants to merge 1 commit into
Open
feat(design): add configurable menu position and scrollable overflow#4541xelaint wants to merge 1 commit into
xelaint wants to merge 1 commit into
Conversation
xelaint
added
package: design
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #4202
Fixes: #4533
New behavior
Add
xPosition(before/after) andyPosition(above/below) inputs to the menu activator so a menu can open above or below its activator and align to either edge. Position is threaded throughDaffMenuConfiginto the overlay's connected position and its max-height calculation, so the panel stays anchored to the activator and scrolls its content in place when it is taller than the available space.Breaking change?
Additional context