Create new viewport component to replace DaffSidebarViewport#4552
Draft
damienwebdev wants to merge 4 commits into
Draft
Create new viewport component to replace DaffSidebarViewport#4552damienwebdev wants to merge 4 commits into
damienwebdev wants to merge 4 commits into
Conversation
damienwebdev
force-pushed
the
refactor-sidebar-viewport
branch
from
fbdc04b to
0ead07e
Compare
xelaint
force-pushed
the
refactor-sidebar-viewport
branch
from
c713770 to
bc3402f
Compare
xelaint
force-pushed
the
refactor-sidebar-viewport
branch
from
cc86cbc to
bdfcce3
Compare
Member
|
TO DO:
DIFFS:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Currently, the DaffSidebarViewportComponent uses
@angular/animationsand doesn't use signals. It's also rather clunky to use because it doesnt internally handle state which means you have to wire everything up yourself.Fixes: #3528
New behavior
DaffViewportComponent uses signals, no Angular animations and can manage state internally by default.
Breaking change?
Additional context