Bump test database to mysql:8.4#72
Merged
Merged
Conversation
MySQL 8.4 makes caching_sha2_password the mandatory default auth plugin. morphism connects via PDO/mysqlnd (graze/php-alpine:7.4), which supports caching_sha2_password natively, so no client change is needed — unlike the mysql CLI in the graze/new-php images, which required mariadb-connector-c for the plugin. Verified the full functional flow (diff --apply-changes, dump, mysqldump, lint, extract) against mysql:8.4. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the local/CI functional-test MySQL service to run on MySQL 8.4, aligning the test environment with MySQL 8.4’s default caching_sha2_password authentication behavior.
Changes:
- Bump the
dbservice image indocker-compose.ymlfrommysql:8.0tomysql:8.4.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dbservice indocker-compose.ymlfrommysql:8.0tomysql:8.4.Context
MySQL 8.4 makes
caching_sha2_passwordthe mandatory default auth plugin. This mirrors the MySQL 8.4 work done in docker.morphism connects exclusively via PDO/mysqlnd, which supports
caching_sha2_passwordnatively (mysqlnd + openssl). It never shells out to the alpine mysql CLI —mysqldumpin the functional test runs inside thedbcontainer itself. So no image swap is required here; the version bump is the whole change.Test plan
mysql:8.4:diff --apply-changes yes,diff,dump,mysqldump,lint,extract— all pass (PDO auth against caching_sha2_password succeeds).Functional testsjob goes green (uses this same compose file).🤖 Generated with Claude Code