fix: avoid redundant feature reloads during sticky bucket refresh#124
Open
vazarkevych wants to merge 1 commit into
Open
fix: avoid redundant feature reloads during sticky bucket refresh#124vazarkevych wants to merge 1 commit into
vazarkevych wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
_get_sticky_bucket_attributes()called_get_eval_context()once per sticky-bucket identifier attribute._get_eval_context()runs_ensure_fresh_features()→load_features(), so on theset_attributes()path (where the_is_updating_featuresguard is not set) this triggered N redundant feature reloads per refresh - one per identifier attribute - each re-runningset_features()and the sticky-bucket service lookup.How
_build_eval_context()._get_eval_context()now =_ensure_fresh_features()+_build_eval_context(), so the main eval paths (run/eval_feature) keep lazy refresh unchanged._get_sticky_bucket_attributes()builds the context once via_build_eval_context()→ no reloads during refresh.Also hardened
eval_prereqs(): a non-dict prerequisite condition is now skipped instead of crashing inevalCondition(...).items().