feat(com): passed first communication - #25
Merged
Merged
Conversation
Communicated with mobile app first time
github-actions
Bot
added
default:unclassified
github-project-automation
Bot
moved this from 📥 Inbox / Ideas
to Done
in hexaTune Project
husamettinarabaci
added a commit
that referenced
this pull request
Oct 22, 2025
* feat(setup): added basic at command (#19) Added basic at command implementation. It support usb-midi sysex protocol * feat(setup): setted up pre commit hooks (#20) Added reuse prettier commitlint hook * feat(setup): setted up pre commit hooks (#21) Added reuse prettier commitlint hook 3 * feat(async): setted up async tasks (#23) Added rgb usb at async tasks and channel before firmware update * feat(firmware): added basic firmware update (#24) Added simple bootsel FWUPDATE command to At * feat(com): passed first communication (#25) Communicated with mobile app first time * feat(freq): added basic freq handler (#27) Added simple at freq handler not check and control * feat(core): added multi core (#28) System is configured for working multi-core. DDS task is working on the Core-1 and others on the Core-0 * feat(core): at command is made by id based (#29) Changed all message types to at command base and id forced for all at command * docs(basic): added basic docs Added simple documantation for version v1.0.0 (#30)
husamettinarabaci
added a commit
that referenced
this pull request
Oct 30, 2025
* feat(setup): added basic at command (#19) Added basic at command implementation. It support usb-midi sysex protocol * feat(setup): setted up pre commit hooks (#20) Added reuse prettier commitlint hook * feat(setup): setted up pre commit hooks (#21) Added reuse prettier commitlint hook 3 * feat(async): setted up async tasks (#23) Added rgb usb at async tasks and channel before firmware update * feat(firmware): added basic firmware update (#24) Added simple bootsel FWUPDATE command to At * feat(com): passed first communication (#25) Communicated with mobile app first time * feat(freq): added basic freq handler (#27) Added simple at freq handler not check and control * feat(core): added multi core (#28) System is configured for working multi-core. DDS task is working on the Core-1 and others on the Core-0 * feat(core): at command is made by id based (#29) Changed all message types to at command base and id forced for all at command * docs(basic): added basic docs Added simple documantation for version v1.0.0 (#30) * feat(multicore): fixed multicore Fixed channel for multicore tasks * feat(multicore): fixed multicore Fixed channel for multicore tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Communicated with mobile app first time
🧩 Affected Module(s)
Mark the modules impacted by this PR:
This pull request primarily focuses on simplifying and cleaning up the firmware codebase, especially around error handling, RGB LED control, and AT command dispatch. Several unused error variants were removed, code paths were streamlined, and some legacy or unnecessary methods were commented out or deleted. Additionally, a minor update was made to the project configuration files.
Error Handling Cleanup:
Errorenum and their associated error codes infirmware/src/error/mod.rs. This reduces complexity and avoids confusion about error states that are no longer relevant. [1] [2]AT Command Dispatch Simplification:
usb_txparameter from both the dispatcher method and its call site, indicating that USB transmission is now handled elsewhere or is unnecessary for dispatch errors. [1] [2]Firmware Update Flow Adjustment:
unsafeblock from the firmware update handler, simplifying the transition to BOOTSEL mode for firmware updates.RGB LED Task and API Cleanup:
offmethod inRgbLed, clarifying the code and preventing accidental use.Project Configuration Update:
pnpm-lock.yamlto the list of tracked files inREUSE.tomlfor better package management and license compliance.