Repository navigation
feat(core): added multi core - #28
Merged
Merged
Conversation
System is configured for working multi-core. DDS task is working on the Core-1 and others on the Core-0
husamettinarabaci
added a commit
that referenced
this pull request
Oct 22, 2025
* feat(setup): added basic at command (#19) Added basic at command implementation. It support usb-midi sysex protocol * feat(setup): setted up pre commit hooks (#20) Added reuse prettier commitlint hook * feat(setup): setted up pre commit hooks (#21) Added reuse prettier commitlint hook 3 * feat(async): setted up async tasks (#23) Added rgb usb at async tasks and channel before firmware update * feat(firmware): added basic firmware update (#24) Added simple bootsel FWUPDATE command to At * feat(com): passed first communication (#25) Communicated with mobile app first time * feat(freq): added basic freq handler (#27) Added simple at freq handler not check and control * feat(core): added multi core (#28) System is configured for working multi-core. DDS task is working on the Core-1 and others on the Core-0 * feat(core): at command is made by id based (#29) Changed all message types to at command base and id forced for all at command * docs(basic): added basic docs Added simple documantation for version v1.0.0 (#30)
husamettinarabaci
added a commit
that referenced
this pull request
Oct 30, 2025
* feat(setup): added basic at command (#19) Added basic at command implementation. It support usb-midi sysex protocol * feat(setup): setted up pre commit hooks (#20) Added reuse prettier commitlint hook * feat(setup): setted up pre commit hooks (#21) Added reuse prettier commitlint hook 3 * feat(async): setted up async tasks (#23) Added rgb usb at async tasks and channel before firmware update * feat(firmware): added basic firmware update (#24) Added simple bootsel FWUPDATE command to At * feat(com): passed first communication (#25) Communicated with mobile app first time * feat(freq): added basic freq handler (#27) Added simple at freq handler not check and control * feat(core): added multi core (#28) System is configured for working multi-core. DDS task is working on the Core-1 and others on the Core-0 * feat(core): at command is made by id based (#29) Changed all message types to at command base and id forced for all at command * docs(basic): added basic docs Added simple documantation for version v1.0.0 (#30) * feat(multicore): fixed multicore Fixed channel for multicore tasks * feat(multicore): fixed multicore Fixed channel for multicore tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System is configured for working multi-core. DDS task is working on the Core-1 and others on the Core-0
🧩 Affected Module(s)
Mark the modules impacted by this PR:
This pull request introduces several improvements and refactorings to the firmware codebase, focusing on better naming consistency, improved task management, and enhanced error handling. The most significant changes include the introduction of multicore task spawning for improved concurrency, renaming variables for clarity, and correcting a spelling error in the error enum and its usage. Additionally, minor enhancements were made to USB MIDI packet processing and main loop status reporting.
Multicore and Task Management Improvements:
firmware/src/main.rsto use multicore task spawning: tasks are now distributed between two executors running on separate cores, withdds_taskrunning on core 1 and other tasks (AT, USB, RGB, and a new main loop) running on core 0 for better parallelism and responsiveness. Also added amain_loop_taskto blink the LED and report system status via AT commands. [1] [2]Naming Consistency and Clarity:
vertoversion_paramorid_paramin AT command handlers for improved clarity and maintainability. [1] [2]Error Handling and Consistency:
Errorenum: changedInvalidDataLenghttoInvalidDataLengthand updated all references to this error throughout the codebase, ensuring consistent error reporting. [1] [2] [3]USB MIDI Packet Processing:
Minor Build and Import Cleanups:
license-fileentry fromCargo.tomland performed minor import cleanups inmain.rs. [1] [2]Let me know if you want to discuss any specific part of these changes in more detail!