Skip to content

add session to the arguments of switch_page fn - #457

Open
russHyde wants to merge 1 commit into
hadley:mainfrom
russHyde:patch-3
Open

add session to the arguments of switch_page fn#457
russHyde wants to merge 1 commit into
hadley:mainfrom
russHyde:patch-3

Conversation

@russHyde

Copy link
Copy Markdown
Contributor

The text describes how the 'switch_page' function can be brought outside of the 'server' function if a 'session' argument is added to it.
But, the definition of 'switch_page' in the subsequent code block did not have a 'session' argument.
Hence, 'session' arg was added in (and passed to updateTabsetPanel).

Hope this makes sense, and I haven't misunderstood the original code.


Also wondering whether updateTabsetPanel should be passed an explicit 'inputId = ...' rather than implicit 'input = ...'

The text describes how the 'switch_page' function can be brought outside of the 'server' function if a 'session' argument is added to it.
But, the definition of 'switch_page' in the subsequent code block did not have a 'session' argument.
Hence, 'session' arg was added in (and passed to updateTabsetPanel).

Hope this makes sense, and I haven't misunderstood the original code.
@hadley

hadley commented Mar 26, 2021

Copy link
Copy Markdown
Owner

Gah, this whole section needs to be re-written because updateTabsetPanel no longer needs the session argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants