Replace the dummy theme spec with overlay and journey tests - #41
Open
MustafaGood wants to merge 1 commit into
Open
MustafaGood wants to merge 1 commit into
MustafaGood wants to merge 1 commit into
Conversation
…amples for the core journeys.
MustafaGood
force-pushed
the
feat/theme-specs
branch
from
August 26, 2026 21:42
85403d9 to
1c72297
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testing the truthspec with a real theme suite: Stripe and reCAPTCHA overlay contracts, plus controller examples for frontpage, sign-in and/body.handlingar-themeviaALAVETELI_TEST_THEME(same hook as other Alaveteli themes). Run from the Alaveteli app:docker compose exec -e RAILS_ENV=test app bundle exec rspec lib/themes/handlingar-theme/spec.ruby script/check-overlay-contracts.rbso PRs catch Stripe/captcha/chrome regressions without booting Rails.Test plan
overlay-contractsis green on this PRruby script/check-overlay-contracts.rbdocker compose exec -e RAILS_ENV=test app bundle exec rspec lib/themes/handlingar-theme/specDo not merge to main.