Translate English nav and use locale-aware menu routes - #45
Open
MustafaGood wants to merge 1 commit into
Open
Conversation
…aware Pro and blog routes instead of hardcoded /sv/ URLs.
MustafaGood
force-pushed
the
feat/nav-menu-routes
branch
from
August 26, 2026 21:42
2037f76 to
5030be9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/enshowed Swedish nav labels because theme strings likeServicesonly existed inlocale-theme/sv. FastGettext fell back to the default locale (Swedish) and renderedTjänster.Services,ProandMain navigation.handlingar.se/sv/...). Pro is hidden when Alaveteli Pro is off so the link cannot 404.Closes #5
Test plan
/entop nav: Make a request, View authorities, Pro (if enabled), Services, Help. All English, not Tjänster/svtop nav: Gör en begäran, Visa myndigheter, Tjänster, Hjälp/proor/en/pro, not/sv/profrom the English siteBLOG_FEEDis set) usesblog_path.pochangesDo not merge to main.