Add HTML and CSS validators and fix duplicate navigation ids - #46
Open
MustafaGood wants to merge 1 commit into
Open
MustafaGood wants to merge 1 commit into
MustafaGood wants to merge 1 commit into
Conversation
… same navigation id twice.
MustafaGood
force-pushed
the
feat/html-css-validate
branch
from
August 26, 2026 21:42
544cd44 to
e9bce3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
id="navigation"twice (main menu and subnav). HTML validators reject duplicate ids. Subnav is nownav#subnavwith its own label; CSS still uses.subnav.custom.scss.html-validateandstylelintin GitHub Actions against chrome fixtures (same idea as axe-smoke: the theme is not a standalone app).If PR #40 lands first,
package.jsonwill need a rebase so both script sets remain.Test plan
html-validate and stylelintis greennpm run html-validateandnpm run stylelintlocallyid="navigation"in the DOMDo not merge to main.