[ci]: run the full attention test directory in the unit lane - #1658
[ci]: run the full attention test directory in the unit lane#1658SolitaryThinker wants to merge 1 commit into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Merge Protections🔴 1 of 1 protections blocking · waiting on 👀 reviews and 🤖 CI
🔴 PR merge requirementsWaiting for
This rule is failing.
|
|
Lane result ( All 11 files in the directory now collect — per file:
The two that motivated the change — the per-arch ATTN_QAT_INFER capability Worth stating plainly: the skips are not incidental. The unit-lane image has |
Problem
run_unit_testcollects whole directories —fastvideo/tests/api/,.../train/,.../stages/,.../ops/— but fromfastvideo/tests/attention/it names exactly one file:The other ten files in that directory run in no PR lane at all. Among
them are the regression tests for the attention selection surface —
test_selector_role_override.py(per-role backend overrides) andtest_attn_qat_infer_arch_gate.py(the per-arch ATTN_QAT_INFER capabilitysets) — plus the custom-op boundary tests for FA2/FA3, the masked/varlen
path, and FP4 FA4.
Those are precisely the tests that catch a silently mis-resolved attention
backend, which is a failure mode that produces output rather than an error.
A file-by-file selection also means every new test added to that directory
starts life uncollected, and nothing says so.
What changes
Collect the directory:
Every file in it is safe on the lane's L40S runner. The GPU/kernel-dependent
ones already gate themselves —
pytest.skipontorch.cuda.is_available(),on
flash_attn/flash_attn.cuteimportability, on bf16 support, and amodule-level
find_spec("flash_attn")guard in the resolver test. The rest(
test_attn_qat_infer_arch_gate.py,test_selector_role_override.py,test_attn_qat_train_kernel.py,test_sdpa_head_sizes.py,test_attention_metadata_base.py,test_video_sparse_attention_metadata.py)are CPU tests that monkeypatch their device and import probes; the VSA
backend module guards its
fastvideo_kernelimport, so importing it withoutthe kernel is fine.
A test in
test_pr_test.pynow pins the directory form, so the collectioncannot silently narrow back to a file list.
Evidence
The lane itself.
microscope-unit-testson this PR runs the new selection —if any of the newly collected files is not lane-safe, it fails here rather
than after a merge.
Note for reviewers
The open #1494 contains this same one-line widening as part of a much larger
change, and has been conflicting since mid-July. Landing it separately closes
the coverage hole now and removes one hunk from that PR's rebase; the
directory-form assertion added here is new.