Digitalocean multitags - #124
Open
abaez wants to merge 4 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working #112, I noticed that the multi tags ability was also missing for another service provider I tend to use; DigitalOcean. I have gone ahead and added the ability.
Also included in this PR is a small change to discover a node if the node has only a public IP on DigitalOcean. Since DigitalOcean's private network isn't always enabled, a node that doesn't have a private IP on DigitalOcean wouldn't be matched regardless of its tag match. The change here is to fall back to check for the public IP when the private IP is not available.