Skip to content

refactor(frontend): split agent configuration tabs - #2933

Merged
nessie993 merged 28 commits into
mainfrom
agent/org-chart-people-processor-routing
Aug 5, 2026
Merged

nessie993 merged 28 commits into
mainfrom
agent/org-chart-people-processor-routing

Conversation

@nessie993

@nessie993 nessie993 commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • flatten the agent details sidebar and split General from Runtime
  • group name, avatar, instructions, conversation starters, and org context under General
  • group display controls under Sandbox settings and hide fixed org-agent type controls
  • move org subscriptions, tools, and project access to their matching tabs
  • remove copied panel backgrounds and borders

Verification

  • cd frontend && yarn build
  • live browser verification against an org-chart agent at http://localhost:8080
  • verified General/Runtime sidebar navigation, legacy tab redirects, fixed agent-type visibility, and org settings placement

@chocobar

chocobar commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI Failure Analysis

Build: #3309
Failed Step: build-frontend (yarn test)

Root Cause

The test InteractionContainer.test.tsx is failing because commit 328bd1a changed the assistantForeground color value in chatStyles.ts without updating the corresponding test assertion.

Change in chatStyles.ts:

- assistantForeground: dark ? 'rgba(245, 245, 245, 0.8)' : 'rgba(24, 24, 27, 0.8)',
+ assistantForeground: dark ? '#e8e8e8' : 'rgba(24, 24, 27, 0.8)',

Test expects:

expect(message).toHaveStyle({ color: 'rgba(245, 245, 245, 0.8)' })

But receives:

color: rgb(232, 232, 232)  // which is #e8e8e8

Fix

Update frontend/src/components/session/InteractionContainer.test.tsx line 19:

- expect(message).toHaveStyle({ color: 'rgba(245, 245, 245, 0.8)' })
+ expect(message).toHaveStyle({ color: '#e8e8e8' })

Or using rgb() format:

- expect(message).toHaveStyle({ color: 'rgba(245, 245, 245, 0.8)' })
+ expect(message).toHaveStyle({ color: 'rgb(232, 232, 232)' })

@chocobar

chocobar commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI Failure: Frontend test failure in build-frontend step

Build: #3310
Commit: 494c8be2b156fb2cdb88da8f80babcc2d44bf0cc

Failing Test

src/components/session/InteractionContainer.test.tsx

Test: InteractionContainer chat typography > uses T3 foreground opacity for assistant messages

Root Cause

The commit changed assistantForeground in frontend/src/components/session/chatStyles.ts from:

assistantForeground: dark ? 'rgba(245, 245, 245, 0.8)' : 'rgba(24, 24, 27, 0.8)'

to:

assistantForeground: dark ? '#e8e8e8' : 'rgba(24, 24, 27, 0.8)'

The test in InteractionContainer.test.tsx still expects the old value rgba(245, 245, 245, 0.8) but receives rgb(232, 232, 232) (the computed form of #e8e8e8).

Fix

Update the test expectation in frontend/src/components/session/InteractionContainer.test.tsx (line 20) to match the new color value:

- expect(message).toHaveStyle({ color: 'rgba(245, 245, 245, 0.8)' })
+ expect(message).toHaveStyle({ color: '#e8e8e8' })

@nessie993
nessie993 merged commit c644309 into main Aug 5, 2026
1 check passed
@nessie993
nessie993 deleted the agent/org-chart-people-processor-routing branch August 5, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants