Skip to content

test(e2e): assert streamed content before completion - #106

Merged
chocobar merged 1 commit into
mainfrom
fix/e2e-phase15-progress
Sep 28, 2026
Merged

chocobar merged 1 commit into
mainfrom
fix/e2e-phase15-progress

Conversation

@chocobar

Copy link
Copy Markdown

Change

  • Replace Phase 15's provider-dependent >=40 message_added threshold with a check for assistant content visible before completion.
  • Keep the existing gap and final-window checks, so delayed streaming still fails.
  • Cover duplicate snapshots, the failed Helix build 4644 content pattern, and terminal-only output.
  • Pass provider keys to the Docker test container without placing their values in process arguments.

Verification

  • Prime: go test -mod=mod -modfile=phase15-test.mod ./... passed for the E2E test server package.
  • Prime: live Claude E2E passed all 17 phases, including Phase 15, with claude-agent-acp@0.82.0 (exit 0).
  • bash -n run_docker_e2e.sh and git diff --check passed.

Pinned by helixml/helix#3309.

@chocobar
chocobar merged commit 9c86adf into main Sep 28, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant