migrate to Typescript

[horacioh]

is there any interest in migrating this package to Typescript?

I can help with the migration, I'm using it for a client in a Typescript codebase and I think it would be useful since the package is not that big.

let me know!

[maxhudson]

Possibly! It would be pretty quick as the 3.0.1 codebase is very small. What would be involved besides changes to code? How would it affect existing non-ts projects? Max

…

On Wed, Jun 5, 2019 at 6:09 AM Horacio Herrera ***@***.***> wrote: is there any interest in migrating this package to Typescript? I can help with the migration, I'm using it for a client in a Typescript codebase and I think it would be useful since the package is not that big. let me know! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#61?email_source=notifications&email_token=AB4MRJ7UARDR3IN7CHQ4FPLPY63INA5CNFSM4HTXQO32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXYPM5Q>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4MRJ67WY6DCBAC5YXECC3PY63INANCNFSM4HTXQO3Q> .

[horacioh]

non-ts codebases will not be affected. maybe they will still benefit from it if you are using an IDE like VSCode that will still read the types for the components you use to give you some instrospection and help. :)

I can start doing the migration if you want

[maxhudson]

What work would be involved besides changes to code? Would the package need to change its structure? Would we need to publish an additional file?

[horacioh]

we need to setup the project to work with typescript + publish the type definitions.. I can do all the setup in my fork and create a PR if you want!

[maxhudson]

Yeah sounds good! Will be happy to accept if it doesn't create any issues for existing users. Thanks.

[codler]

I hope this will create a TypeScript definition also

[piro0919]

I created the type definitions. 👍

import * as React from "react";

declare module "react-sticky-table" {
  export type StickyInsets = {
    footer: number[];
    header: number[];
    leftColumn: number[];
    rightColumn: number[];
  };

  export type StickyTableProps = {
    borderColor?: string;
    borderWidth?: number | string;
    children?: React.ReactNode;
    footerZ?: number;
    headerZ?: number;
    leftColumnZ?: number;
    leftStickyColumnCount?: number;
    rightColumnZ?: number;
    rightStickyColumnCount?: number;
    stickyFooterCount?: number;
    stickyHeaderCount?: number;
    stickyInsets?: StickyInsets;
    wrapperRef?: React.Ref<HTMLDivElement>;
  } & React.HTMLAttributes<HTMLDivElement>;

  export class StickyTable extends React.Component<StickyTableProps> {}

  export const Table: React.ComponentType<React.HTMLAttributes<HTMLDivElement>>;
  export const Row: React.ComponentType<React.HTMLAttributes<HTMLDivElement>>;
  export const Cell: React.ComponentType<React.HTMLAttributes<HTMLDivElement>>;
}