Custom svg transformer#18
Open
emilianobovetti wants to merge 4 commits into
Open
Conversation
emilianobovetti
force-pushed
the
svgTransformer
branch
2 times, most recently
from
October 30, 2019 22:26
313c6c6 to
4a175ec
Compare
Using @svgr/plugin-svgo seems to fix some rendering issues
`@apollo/react-hooks@^0.1.0-beta.10` produces an odd bug: Worked fine with `react-native-svg-transformer`, throws an exception with `@hitbit/expo-svg-transformer`. For some obscure reason the `useQuery` in Home screen couldn't find the client object as if it wasn't mounted inside an `ApolloProvider`. This upgrade seems to fix the issue.
Make the web great again
emilianobovetti
force-pushed
the
svgTransformer
branch
from
November 5, 2019 10:49
4a175ec to
191ef5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-native-svg-transformer funziona bene, ma per qualche motivo ho dei problemi di rendering sul mio telefono: visualizzo il logo, ma non vedo le icone. Non ho idea del motivo. Aggiungere svgo alla pipeline di svgr sembra risolvere il problema.
Più di una review del codice (che sono venti righe) sarebbe utile che controllaste se avete problemi di rendering con questa soluzione prima di fare il merge.