docs(rules): tell a shipped spec from a plan not yet built - #153
Conversation
Time Submission Status
Submit or update total time with: Add time on top of previous submission with: See available commands to help comply with our Guidelines. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughDEV-180 now separates product documentation from unbuilt specs. It defines how shipped behavior moves out of specs, how product documentation records non-obvious behavior, and when Goals and completed specs may close or remain. ChangesSpec and Product Documentation
Estimated code review effort: 1 (Trivial) | ~4 minutes Merge Risk: ⚪ Minimal · up to This localized documentation update is merge-ready after normal checks and review; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@holdex pr add-time 13m |
DEV-180 said to move spec sections into the product docs, but never said why, so the step read as filing work and got skipped on the way to closing a Goal. It now opens with the reason: the product (the app and its end-user docs) is the one source of truth for what exists, and the spec is the one source of truth for what stakeholders still want.
The Problem now names the cost that actually bites. A spec left behind after its behavior ships is indistinguishable from a plan, so readers take shipped work for unbuilt, and the stale text collides with the next spec written for the same feature.
The Solution gains the judgement call that was missing. Product docs are part of the product, carrying what a user cannot work out from the screen alone, so a delivered section graduates only when the UI does not already make it obvious. Everything else is dropped rather than copied, which keeps the docs from bloating into a restatement of the interface.
Two mechanical gaps close with it. The product docs path stays
docs/product/by default and allows a repo to declare its own, and a Goal can no longer be closed while its spec still describes shipped behavior, which is the point where this was being missed.Both changes are checkable, and the audit and markdown lint pass.
Summary by CodeRabbit