fix(activesync): do not buffer Search keep-alive output - #223
Open
TDannhauer wants to merge 2 commits into
Open
Conversation
Skip ob_start around mailbox search when a progress callback is present so WBXML keep-alives reach the client. Exclude the callback from the search cache key.
This was referenced Sep 9, 2026
…ache Do not cache time-truncated mailbox Search results, and omit deadline and stats from the cache key so keep-alive callbacks cannot poison it.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Streaming Search emits WBXML keep-alives during a long IMAP scan so Gmail’s 30s read timeout does not abort the request (horde/ActiveSync#104).
getSearchResults()wrapped that work inob_start(), which would swallow those bytes.Changes
ob_start()/_endBuffer()whenoptions['progress']is callable.progressfrom the search-result cache key so a Closure is not serialized.Companion: ActiveSync Search streaming + IMAP date-chunking; RPC streams
Cmd=Search.Test plan
RebuildResultsis set