Repository navigation
fix(queue): resolve queue ViewController via injector to match new signature - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visiting a queue view (e.g. https://bugs.horde.org/queue/beatnik) via the legacy
queue/index.phpentry point produced a fatal type error:The controller was refactored to take nine typed dependencies (driver, notification, pageOutput,
Horde_Registry,HordeSession,TicketSorter,TopbarSearch,UrlGenerator,PrefsService), butqueue/index.phpwas still hand-constructing it with the old six-argument signature. Position 4 collided:$sessionlanded where$registrywas expected.Replaced the manual
new ViewController(...)with$injector->getInstance(ViewController::class), matching the pattern already used byticket/delete_attachment.php,ticket/delete_history.php, andticket/rss.php. The container resolves all nine dependencies from bindings already registered inlib/Application.php.