CON-4502: Fixed issues reported by MCP - #549
Conversation
Signed-off-by: kalikivayi <suresh.kalikivayi@hpe.com>
| // to snake_case for the CSP. They are used to detect when array-based | ||
| // replication is requested so that unsupported protocol combinations (e.g. | ||
| // NVMe/TCP + replication, CROSS-2) can be rejected early in the driver. | ||
| remoteCopyGroupKey = "remoteCopyGroup" |
There was a problem hiding this comment.
I understand the intent of validating the SC parameters as soon as possible, but this should not be done in the CSI Driver. These parameters are best understood by the CSP and it should be validated in the CSP. Bringing that logic here, will violate the current architecture of keeping CSI Driver generic.
CC: @datamattsson , @dileepds
| return nil | ||
| } | ||
|
|
||
| // isReplicationRequested reports whether the supplied StorageClass/PVC create |
There was a problem hiding this comment.
CSI Driver is not aware of what Replication is. We should not be doing these validations here. I prefer these to be moved to the CSP.
CC: @datamattsson , @dileepds
datamattsson
left a comment
datamattsson
left a comment
There was a problem hiding this comment.
Can we break this down to 53 different PRs instead and start with the most critical issue that we're trying fix?
Submit CSI e2e test results from each supported CSP with each PR.
3 participants
This PR contains Fixes reported by the AI.
Analyzed the report and fixed the issues marked for Fixing in the attached Excel sheet.
3par-csi-issues-analysis.xlsx
3par-csp.md