Repository navigation
Add DETR to NormalizedConfigManager - #2510
Open
kratos0718 wants to merge 1 commit into
Open
kratos0718 wants to merge 1 commit into
kratos0718 wants to merge 1 commit into
Conversation
DETR has an ONNX export config but was missing from NormalizedConfigManager. Its config exposes hidden_size, num_attention_heads and num_hidden_layers through its own attribute_map (aliasing d_model, encoder_attention_heads and encoder_layers respectively), so plain NormalizedTextConfig resolves them with no custom optimum-side mapping needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #351. DETR already has an ONNX export config but was missing from
NormalizedConfigManager, soORTOptimizercan't run on it yet."detr": NormalizedTextConfigto_conf(alphabetically, betweendeitanddinov2)detrfrom theTODO: missing normalized configscomment above itUnlike the other recent additions on this issue (ConvNeXT, BEiT, LeViT, etc., all vision models needing
NormalizedVisionConfig), DETR needs its transformer encoder stats:hidden_size,num_attention_heads,num_hidden_layers.DetrConfigstores these underd_model,encoder_attention_heads, andencoder_layers, butDetrConfig.attribute_mapalready aliases all three to the namesNormalizedTextConfiglooks for, sogetattr(config, "hidden_size")etc. resolves directly with no customwith_args(...)mapping needed (unlike e.g.BartLikeNormalizedTextConfig, whose config doesn't have this alias).Test plan
tests/utils/test_normalized_config.py: one confirmingdetrresolves toNormalizedTextConfig, and one instantiating a realDetrConfig()and asserting the normalizedhidden_size/num_attention_heads/num_layersmatchd_model/encoder_attention_heads/encoder_layerstransformers.DetrConfig(not mocked) — both pass