Repository navigation
Fix safetensors detection in try_collect_weight_map (missing dot in glob) - #2520
Open
iamgrootns wants to merge 1 commit into
Open
iamgrootns wants to merge 1 commit into
iamgrootns wants to merge 1 commit into
Conversation
…lob) try_collect_weight_map builds patterns as ["*safetensors", "*.bin"] but compares against "*.safetensors", so use_safetensors is always False even for safetensors-only models. This causes wrong index (pytorch_model.bin.index.json) and empty weight_files. Add missing dot to match sibling globs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
optimum/fx/parallelization/utils.py:467try_collect_weight_mapbuilds patterns as["*safetensors", "*.bin"]but comparespattern == "*.safetensors"on line 470.Since glob("*safetensors") still matches model.safetensors files, the loop breaks but use_safetensors stays False.
Impact for safetensors-only model:
Verified locally with synthetic sharded dir: buggy -> False + wrong index, fixed -> True + correct index.
Fix
Matches sibling globs on lines 473, 489.