Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@optimum_cli_subcommand()registers a command but returnsNone, replacing the decorated class binding. The registered CLI command still runs, but the class cannot be instantiated, subclassed or reused in aCommandInfofor static registration.Return the original command class after registration. The two regression cases cover root commands and children of the existing
ExportCommand: the decorated class remains usable for static registration and execution, and registration through the actual CLI still works.Local validation on Windows, Python 3.12:
CommandInfoand CLI probe: unchanged main has 7 failures and 5 normal controls; the fix passes all 12 cases.The model-export CLI test was deselected. Full model/export integrations, accelerator backends, other operating systems and performance were not tested.
Before submitting