feat(hydro_lang,dfir_rs)!: place Tokio dependencies behind a feature flag#2960
Open
shadaj wants to merge 2 commits into
Open
feat(hydro_lang,dfir_rs)!: place Tokio dependencies behind a feature flag#2960shadaj wants to merge 2 commits into
shadaj wants to merge 2 commits into
Conversation
Deploying hydro with
|
| Latest commit: |
bb5a9de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://49010524.hydroflow.pages.dev |
| Branch Preview URL: | https://no-required-tokio-dep.hydroflow.pages.dev |
shadaj
added a commit
that referenced
this pull request
Jun 19, 2026
shadaj
force-pushed
the
remove-tokio-dep-sinktools
branch
from
e72392b to
0a97dda
Compare
shadaj
force-pushed
the
no-required-tokio-dep
branch
from
c4dc063 to
47e654a
Compare
shadaj
added a commit
that referenced
this pull request
Jun 19, 2026
shadaj
force-pushed
the
no-required-tokio-dep
branch
from
47e654a to
f231534
Compare
Member
Author
|
Validated with: |
shadaj
added a commit
that referenced
this pull request
Jun 19, 2026
shadaj
force-pushed
the
no-required-tokio-dep
branch
from
f231534 to
85ca216
Compare
shadaj
added a commit
that referenced
this pull request
Jun 19, 2026
shadaj
force-pushed
the
no-required-tokio-dep
branch
from
85ca216 to
86bf036
Compare
shadaj
added a commit
that referenced
this pull request
Jun 19, 2026
shadaj
force-pushed
the
no-required-tokio-dep
branch
from
86bf036 to
4b7e1e1
Compare
luckyworkama
approved these changes
Jun 19, 2026
shadaj
added a commit
that referenced
this pull request
Jun 19, 2026
shadaj
force-pushed
the
no-required-tokio-dep
branch
from
4b7e1e1 to
75ae1ce
Compare
shadaj
added a commit
that referenced
this pull request
Jun 19, 2026
shadaj
force-pushed
the
no-required-tokio-dep
branch
from
75ae1ce to
11099af
Compare
shadaj
added a commit
that referenced
this pull request
Jun 19, 2026
shadaj
force-pushed
the
no-required-tokio-dep
branch
from
11099af to
3222731
Compare
shadaj
changed the title
MingweiSamuel
approved these changes
Jun 19, 2026
Comment on lines
+35
to
+42
| #[cfg_attr( | ||
| docsrs, | ||
| doc(cfg(any( | ||
| feature = "deploy", | ||
| feature = "deploy_integration", | ||
| feature = "embedded_runtime" | ||
| ))) | ||
| )] |
Member
There was a problem hiding this comment.
I believe we can remove cfg_attr now, they updated it to be included automatically. Can do that in a new pr
Added `features` field and `.features()` / `.feature()` builder methods to `DockerDeployProcessSpec` and `DockerDeployClusterSpec`, matching the API available on `TrybuildHost`. Features are threaded through to the `RustCrate` at compile time during `instantiate()`. Co-authored-by: Infinity 🤖 <infinity@hydro.run> PR: #2973
shadaj
force-pushed
the
no-required-tokio-dep
branch
from
3222731 to
bb5a9de
Compare
shadaj
changed the base branch from
main
to
sandbox-7d0b037a-e634-4cf4-996c-099e82e0a733
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Changes:
hydro_lang::telemetry::emfmodule now requires the non-defaulttelemetry_emffeature