Skip to content

refactor(dfir_lang): remove stratum from chain, chain_first_n#2967

Open
MingweiSamuel wants to merge 1 commit into
mingwei/newpush-reducefrom
mingwei/newpush-chain
Open

refactor(dfir_lang): remove stratum from chain, chain_first_n#2967
MingweiSamuel wants to merge 1 commit into
mingwei/newpush-reducefrom
mingwei/newpush-chain

Conversation

@MingweiSamuel

Copy link
Copy Markdown
Member

No description provided.

@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from a23896f to 93a7278 Compare June 19, 2026 20:44
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-chain branch from 7dc055f to 0bc8b75 Compare June 19, 2026 20:44
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from 93a7278 to d8a1f65 Compare June 19, 2026 20:59
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-chain branch from 0bc8b75 to d07eaf0 Compare June 19, 2026 20:59
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 19, 2026

Copy link
Copy Markdown

Deploying hydro with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff6cd2f
Status: ✅  Deploy successful!
Preview URL: https://026f7e95.hydroflow.pages.dev
Branch Preview URL: https://mingwei-newpush-chain.hydroflow.pages.dev

View logs

@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from d8a1f65 to 870055e Compare June 19, 2026 21:02
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-chain branch from d07eaf0 to 686eeac Compare June 19, 2026 21:02
@MingweiSamuel MingweiSamuel marked this pull request as ready for review June 19, 2026 21:36
Copilot AI review requested due to automatic review settings June 19, 2026 21:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the DFIR operator definitions for chain and chain_first_n to remove the stratum-delay barrier previously applied to input port 0, simplifying scheduling/partitioning behavior for these operators.

Changes:

  • Removed DelayType::Stratum assignment for chain input port 0 (now no input delay types).
  • Removed DelayType::Stratum assignment for chain_first_n input port 0 (now no input delay types).
  • Cleaned up now-unused imports (DelayType, PortIndexValue).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
dfir_lang/src/graph/ops/chain.rs Removes stratum-delay barrier from chain’s first input and prunes unused imports.
dfir_lang/src/graph/ops/chain_first_n.rs Removes stratum-delay barrier from chain_first_n’s first input and prunes unused imports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dfir_lang/src/graph/ops/chain.rs
Comment thread dfir_lang/src/graph/ops/chain_first_n.rs
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from 870055e to e565624 Compare June 19, 2026 21:46
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-chain branch from 686eeac to a1274c3 Compare June 19, 2026 21:46
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from e565624 to c8d8e3a Compare June 19, 2026 22:05
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-chain branch from a1274c3 to 115f13a Compare June 19, 2026 22:05
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from c8d8e3a to bc727b8 Compare June 20, 2026 01:27
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-chain branch from 115f13a to 45792ef Compare June 20, 2026 01:27
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from bc727b8 to 8a2b324 Compare June 20, 2026 17:11
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-chain branch 2 times, most recently from 5742fa1 to bf6c8d3 Compare June 21, 2026 00:09
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from 8a2b324 to 86682ff Compare June 22, 2026 16:49
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-chain branch 2 times, most recently from 7a59caf to ff6cd2f Compare June 22, 2026 21:40
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from 86682ff to f836d0e Compare June 22, 2026 21:40
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-reduce branch from f836d0e to d69aa91 Compare June 22, 2026 21:40
@MingweiSamuel MingweiSamuel force-pushed the mingwei/newpush-chain branch from ff6cd2f to 3a91784 Compare June 22, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants