refactor(dfir_lang): remove stratum from chain, chain_first_n#2967
Open
MingweiSamuel wants to merge 1 commit into
Open
refactor(dfir_lang): remove stratum from chain, chain_first_n#2967MingweiSamuel wants to merge 1 commit into
chain, chain_first_n#2967MingweiSamuel wants to merge 1 commit into
Conversation
a23896f to
93a7278
Compare
7dc055f to
0bc8b75
Compare
93a7278 to
d8a1f65
Compare
0bc8b75 to
d07eaf0
Compare
Deploying hydro with
|
| Latest commit: |
ff6cd2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://026f7e95.hydroflow.pages.dev |
| Branch Preview URL: | https://mingwei-newpush-chain.hydroflow.pages.dev |
d8a1f65 to
870055e
Compare
d07eaf0 to
686eeac
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the DFIR operator definitions for chain and chain_first_n to remove the stratum-delay barrier previously applied to input port 0, simplifying scheduling/partitioning behavior for these operators.
Changes:
- Removed
DelayType::Stratumassignment forchaininput port0(now no input delay types). - Removed
DelayType::Stratumassignment forchain_first_ninput port0(now no input delay types). - Cleaned up now-unused imports (
DelayType,PortIndexValue).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dfir_lang/src/graph/ops/chain.rs | Removes stratum-delay barrier from chain’s first input and prunes unused imports. |
| dfir_lang/src/graph/ops/chain_first_n.rs | Removes stratum-delay barrier from chain_first_n’s first input and prunes unused imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
870055e to
e565624
Compare
686eeac to
a1274c3
Compare
e565624 to
c8d8e3a
Compare
a1274c3 to
115f13a
Compare
c8d8e3a to
bc727b8
Compare
115f13a to
45792ef
Compare
bc727b8 to
8a2b324
Compare
5742fa1 to
bf6c8d3
Compare
8a2b324 to
86682ff
Compare
7a59caf to
ff6cd2f
Compare
86682ff to
f836d0e
Compare
f836d0e to
d69aa91
Compare
ff6cd2f to
3a91784
Compare
shadaj
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.