fix(infinity-ui): preserve FileTree selection state and scroll position across diff updates#42
Draft
shadaj wants to merge 1 commit into
Draft
fix(infinity-ui): preserve FileTree selection state and scroll position across diff updates#42shadaj wants to merge 1 commit into
shadaj wants to merge 1 commit into
Conversation
…on across diff updates
Memoize the `options` object passed to `<FileTree>` so it maintains a stable
reference. Previously, a new inline object `{ flattenEmptyDirectories: true }`
was created on every render, causing the `@pierre/trees` `useFileTreeInstance`
hook (which has `options` in its `ref` callback dependency array) to destroy
and recreate the entire FileTree instance on each update — resetting both
selection state and scroll position.
Co-authored-by: Infinity 🤖 <infinity@hydro.run>
Deploying infinity with
|
| Latest commit: |
ad9509e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18166331.infinity-dc7.pages.dev |
| Branch Preview URL: | https://sandbox-39bbd64c-3f9c-4b3b-8.infinity-dc7.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memoize the
optionsobject passed to<FileTree>so it maintains a stablereference. Previously, a new inline object
{ flattenEmptyDirectories: true }was created on every render, causing the
@pierre/treesuseFileTreeInstancehook (which has
optionsin itsrefcallback dependency array) to destroyand recreate the entire FileTree instance on each update — resetting both
selection state and scroll position.
Co-authored-by: Infinity 🤖 infinity@hydro.run