Conversation
When group_id is None, str(None) produces the literal string 'None', corrupting every event emitted by the cloned emitter and its descendants. Pass group_id by keyword argument instead, so None stays None. Fixes i-am-bee#1581
Contributor
|
Thanks @re2zero! This is a correct fix for #1581. Two things to note:
We currently have three PRs for #1581; we're leaning toward #1582 (from the issue reporter) as it's already fully reviewed. Thanks for the contribution regardless! 🐝 |
This was referenced Aug 19, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
group_idisNone(the default),str(None)produces the literal string'None'on clone, corrupting every event emitted by the cloned emitter and its descendants.Changes
Emitter.clone()instead of positionally, sogroup_id=NonestaysNone.test_clone_without_group_idthat exercises the default-Nonepath, which the existing test (always usesgroup_id="test_group") never covered.Fixes #1581