Repository navigation
Move outside links before breaking at their end - #6202
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing Enter with a collapsed caret inside the end of a link duplicated an empty link into the next paragraph. Move that caret to the following text node before the example's normal insertBreak runs.
Fixes #4334
Regenerate only the matching JSX. This example-only fix needs no changeset. The override targets link nodes only and delegates the actual paragraph split to the existing handler.
Validation: the link-end regression fails on main 8f59fd3 in Chromium, Firefox and WebKit; the two consequence cases pass on main. All three cases pass twice with the fix in each desktop browser (18 passed / 6 synthetic-mobile cases skipped).
check.sh passed on Node 24.21.0: 1,468 Mocha / 141 Jest tests, build, TypeScript, ESLint and Prettier. Playwright TypeScript also passes.
Full browser suite: 271 passed / 20 skipped / one Chromium Markdown list failure, also reproduced on main 8f59fd3 (2 failures / 10 passes across four Markdown-test repeats). All new link tests pass. The markdown-shortcuts failure is a test-timing flake (a click processed after the keys that follow it), fixed separately in #6205.