Repository navigation
Preserve insertion points when range ends are removed - #6204
Merged
Merged
Conversation
When the replaced range both starts and ends inside voids, the delete removes both, so neither point ref survives and insertNodes would still crash. Take a ref to the point just before the range first and insert there, falling back to the document start.
🦋 Changeset detectedLatest commit: 1766436 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing a selection ending inside an inline or block void could throw after deletion removed the insertion point. Track both endpoints, keep the surviving point, and release both references. When both endpoints are removed, insert at a point taken just before the range, then fall back to the document start. Apply the same fallback to insertFragment for read-only endpoints.
Fixes #4328
Validation: against main 8f59fd3, the four crash fixtures and the start-and-end fixture fail; the two expanded-void fragment fixtures pass. The fixture harness also exercises batched/unbatched insertion. Both references are checked for cleanup. check.sh passed on Node 24.21.0: 1,480 Mocha tests, 141 Jest tests, build, TypeScript, ESLint and Prettier.
The handoff described insertFragment's void endpoint as another crash, but its explicit guard already prevents that. Keeping that guard avoids introducing a new deletion behavior when both endpoints are inside voids. Existing list/table, collapsed void, voids:true and normalization fixtures pass in the full core suite.