Repository navigation
Limit whole-block hanging deletion to top-level blocks - #6287
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 78fd5ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6282 extended whole-block removal for a hanging selection to nested sibling blocks. Editors that don't mark table cells with
editor.isIsolated(every editor written before 0.136) can now lose whole cells when dragging or cutting across them; the table example's Firefox drag test fails on main. The richtext undo-scroll test also fails on main: after undoing a triple-click deletion, the default scroll targets the start of the following block, so the restored paragraph stays off screen.Editor.deleteFragmentremoves whole blocks only for top-level blocks. Nested blocks keep the pre-0.138 behavior.defaultScrollSelectionIntoViewscrolls to the unhung end of a forward hanging selection.Verified locally with retries off: richtext, tables, delete-line, triple-click and scroll-selection suites across Chromium, Firefox, mobile Chromium and WebKit, 129 passed and 19 platform skips. Both failures from CI on main pass. Updated core tests cover nested blocks.
Follow-up to #6282